Disable dragging feature of slide toc #372
Conversation
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-323-fix |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Temporary blocker. I know the issue mentions that we should disable this functionality, but I think we should at least investigate a resolution to the issue. Additionally, if we do intend to remove it we should probably get rid of the draggable component.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
IshavSohal
force-pushed
the
issue-323-fix
branch
from
1d2373b to
5450eb4
Compare
|
I managed to get the dragging of the toc components to work by using the However, I noticed that we're using What would be a good solution for this? Perhaps we could state in the schema that the title of a slide has to be unique, as well as ensuring that the title of new slides are unique before adding them in. |
There was a problem hiding this comment.
Was about to suggest we combine the title + slide index as the key for a simple workaround, but I see that's already being done in the existing code: :key="element.title + index". Does this not work?
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dnlnashed and @szczz)
|
It seems like the issues go away when I set |
IshavSohal
force-pushed
the
issue-323-fix
branch
from
5450eb4 to
eed7b8d
Compare
There was a problem hiding this comment.
Do you mean setting the item-key to empty or a random string? I think Yi-Lei's suggestion of title + index would be preferred as we don't want to leave item-key empty. I've tested the dragging functionality and it works well though.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
IshavSohal
force-pushed
the
issue-323-fix
branch
from
eed7b8d to
6fab590
Compare
|
Yep meant to say |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
Related Item(s)
#323
Changes
v-modelattribute withlistattributeitem-keyto a function that returns a slide's title + index within theslidesarrayTesting
Steps:
This change is